Button colvis + Bootstrap 3 + colReorder problem

Button colvis + Bootstrap 3 + colReorder problem

tsunamotsunamo Posts: 12Questions: 1Answers: 0

Hello, I have noticed that when moving around one column using the colReorder plugin and reopening the column list button the list is not displayed as it should. This is only happening in Bootstrap 3, for Bootstrap 4 or for the default style this does not happen.

Example of the problem:

http://live.datatables.net/lirihode/1

Same code with the standard framework (works correctly):

http://live.datatables.net/kasojiwe/1

Also, besides this problem, in Bootstrap 3 the transition when opening the Colvis button is not seamless.

Thank you in advance,

Alvaro

Replies

  • allanallan Posts: 54,909Questions: 1Answers: 8,606 Site admin

    Hi Alvaro,

    Thank you for this. It looks like a bug in our Bootstrap 3 integration I'm afraid. I've filed it for fixing in the next patch release version. We'll post back here when the fix is committed.

    Allan

  • yayikesyayikes Posts: 4Questions: 0Answers: 0

    We just stumbled into this while upgrading from 1.10.10 to 1.10.20. Makes the upgrade impossible.

    Any updates on this? Interim patch? Or maybe upgrade to something less than 1.10.20?

  • allanallan Posts: 54,909Questions: 1Answers: 8,606 Site admin

    Sorry - we've not had a look into this yet. I'm not actually even sure where the problem was introduced yet - I suspect it is in the Buttons library rather than DataTables 1.10.20 though. Did you upgrade Buttons at the same time?

    Allan

  • yayikesyayikes Posts: 4Questions: 0Answers: 0

    Hi, thanks for the quick reply!

    Yes, we upgraded (or tried to upgrade) everything, using the Download Builder. This is the config we're using:

    https://datatables.net/download/#bs/jszip-2.5.0/pdfmake-0.1.36/dt-1.10.20/b-1.6.1/b-colvis-1.6.1/b-html5-1.6.1/b-print-1.6.1/cr-1.5.2/r-2.2.3/sc-2.0.1

    It appears the current version of Buttons is 1.6.1, whereas we're currently using Buttons 1.1.0 (with DataTables 1.10.10) in production.

    I'm happy to test a different version of Buttons and post results, but not sure which version to try. Any recommendations? Is it viable to mix DataTables 1.10.20 with different versions of Buttons (or other extensions for that matter)?

    I can also try my hand at a PR to fix this, if you give me a hint as to where to look:
    https://github.com/DataTables/Buttons

  • allanallan Posts: 54,909Questions: 1Answers: 8,606 Site admin

    Yes, you can mix versions with our new CDN server. I'd suggest rolling back to Buttons 1.5.6 first, then 1.4.2, etc for the major versions.

    Where to look? I'm not certain yet since I don't actually know what is causing it. It will probably be something to do with the rebuilding of the buttons in the list, but I don't know for sure.

    Allan

  • yayikesyayikes Posts: 4Questions: 0Answers: 0

    Hi, thanks again for the quick reply and the suggestion.

    I'm happy to report Buttons 1.5.6 works perfectly with DataTables 1.10.20! The issue described by tsunamo goes away. YAY!!

    One thing to note, modifying the Download Builder URL to use Buttons 1.5.6 does not work.... so https://datatables.... /b-1.5.6/b-colvis-1.5.6/.... etc. does not work. It reverts to 1.6.1. To get 1.5.6, you must build your own URL from the CDN server. That does work well.

  • allanallan Posts: 54,909Questions: 1Answers: 8,606 Site admin

    Yes - that's expected. The download builder only provides URLs for the latest versions. You'd need to modify the URL a little if you want a different version.

    Thanks for confirming that it works with Buttons 1.5.6. We've got this logged to look at for the next patch release.

    Allan

  • allanallan Posts: 54,909Questions: 1Answers: 8,606 Site admin

    Just to say, this has now been fixed and will be in Buttons 1.5.6 later this week.

    Regards,
    Allan

  • colincolin Posts: 12,940Questions: 0Answers: 2,205

    Here's your example modified to use the nightly releases. But as Allan said, it'll be released shortly.

    Colin

  • tsunamotsunamo Posts: 12Questions: 1Answers: 0

    Thank you @allan and @collin for the fix. This is a minor detail, but could you please look into the transition on click of the Column visibility button? http://live.datatables.net/vigijiwi/1/edit . I feel it's not quite right, specially when opening it the list.

    Thank you again!

    Alvaro

  • colincolin Posts: 12,940Questions: 0Answers: 2,205

    sorry, I gave the wrong link, I meant this: http://live.datatables.net/voxokede/1/edit - but yep, that's showing the transition issue to. we'll take a look and report back,

    Colin

  • colincolin Posts: 12,940Questions: 0Answers: 2,205

    For my information, I've raised the transition issue internally as DD-1419 and we'll report back here when there's an update.

    Cheers,

    Colin

  • washuit-iammwashuit-iamm Posts: 80Questions: 30Answers: 1

    I am still having this issue. Using Bootstrap 4 and latest DataTables, ColReorder, and ColVis.

  • colincolin Posts: 12,940Questions: 0Answers: 2,205

    I'm not seeing it with the link I gave earlier in this thread - see here - which is using the nightly builds. Could you look at that, please, and see if it helps. If it's still not working for you, please can you update my example, or link to your page, so that we can see the problem.

    Cheers,

    Colin

Sign In or Register to comment.